Partials do not respect the indentation from source content

[nswarm]

Partial calls only use indentation defined in the partial template itself.

Example

inner.hbs

name: {{name}}

outer.hbs

                {{> inner inner_solo}}

{{#each inners}}
                {{> inner}}
{{/each}}

        {{#each inners}}
        {{> inner}}
        {{/each}}

main.rs

use std::error::Error;
use handlebars::Handlebars;
use serde_json::json;

fn main() -> Result<(), Box<dyn Error>> {
    env_logger::init();
    let mut hbs = Handlebars::new();

    hbs.register_template_file("inner", "./templates/inner.hbs")?;
    hbs.register_template_file("outer", "./templates/outer.hbs")?;

    let result = hbs.render("outer", &json!({
        "inner_solo": {"name": "inner_solo"},
        "inners": [
            {"name": "hello"},
            {"name": "there"}
        ]
    }))?;
    println!("{}", result);

    Ok(())
}

Result:

name: inner_solo

name: hello
name: there

name: hello
name: there

Handlebars JS Handling

Handlebars js by default uses the indentation of the partial call itself, but has a compiler flag to disable this functionality, see preventIndent in the Handlebars.compile options.

Use Case

I'm using recursively nested partials to render a tree view, so specifying indentation in the target template itself does not work.

--

Thanks for your hard work!

[nswarm]

I've worked around my use case for with a custom block helper that explicitly injects indentation into its rendered content.

[sunng87]

Thank you for reporting! I will look into my template parser to see if preventIndent can be supported.

[TheButlah]

#486 does not appear to have actually solved this. If the text put into the partial spans multiple lines, the next line does not keep the same indentation as the first line.

Also, it appears as though none of the tests for indentation in partials test what happens if the string that is going to be used for the render spans multiple lines.

[TheButlah]

Can this please be reopened? Or should I file a new issue?

[sunng87]

@TheButlah could you please provide me a demo template for reproducing this?

[sunng87]

I've created #504 to track this.

[TheButlah]

@TheButlah could you please provide me a demo template for reproducing this?

Sorry, I just saw this! It looks like you solved it though :)
I'll post in #504 if I have any further bugs