-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow registry to be cloned #397
base: master
Are you sure you want to change the base?
Conversation
Added Clone to registry
Okay yeah this doesn't seem to fix it. Let me try something else |
Can you use an |
Yup. That's what I'm currently using locally. But I'm trying to get this to Clone directly so that we can make multiple copies of the registry that can work independent of each other. I'm trying to use generic parameters. Will update the PR once I get something running |
I'm afraid generic parameters may not work for this. Handlebars-rust uses a lot of dynamic dispatch in render and helper API, which makes |
By the way, I have made |
Ahh, I see you made it into an |
@rakshith-ravi correct me if I'm wrong, but I think right now the registry can be modified independently - it's just the HelperDefs themselves that cannot be. The map itself is cloned so you can just replace the helpers with other ones. |
7abfce6
to
4962d7e
Compare
Added Clone to registry.
Closes #396