Fix handling of identifiers which start with numbers #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's an example of this working in handlebars.js. Without the grammar change in this branch handlebars-rust behaves differently (emitting no output in that example). |
These test cases capture the issue called out in sunng87#450. The handling of identifiers which start with numbers diverges from the official JavaScript implementation of Handlebars. It's especially bad for cases like `{{eq 1a}}`, which validly parses as `{{eq 1 a}}`!
mkantor
force-pushed
the
identifiers-starting-with-numbers
branch
from
f18834b
to
0772349
Compare
|
Thank you @mkantor for the patch! Also feel free to share your ideas with this library, I'm looking for co-maintainers of this project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #450.