Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow public access to local variables #533

Merged
merged 3 commits into from
Sep 25, 2022
Merged

Allow public access to local variables #533

merged 3 commits into from
Sep 25, 2022

Conversation

lovasoa
Copy link
Contributor

@lovasoa lovasoa commented Sep 24, 2022 •
edited
Loading

This makes LocalVars public and gives mutable access to it from BlockContext. I need this for SQLPage

sunng87
sunng87 approved these changes Sep 25, 2022
View reviewed changes
Copy link
Owner

@sunng87 sunng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunng87 sunng87 merged commit 9eaf061 into sunng87:master Sep 25, 2022
@lovasoa lovasoa deleted the get-locals-mut branch September 25, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunng87 sunng87 sunng87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lovasoa @sunng87