Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply clippy fixes #659

Merged
merged 1 commit into from
Jul 14, 2024
Merged

apply clippy fixes #659

merged 1 commit into from
Jul 14, 2024

Conversation

cmrschwarz
Copy link
Contributor

@cmrschwarz cmrschwarz commented Jul 13, 2024

This fixes all 86 warnings that clippy currently generates on this project.
Most of these are in test code and don't really matter.
I still believe this is worth it because it makes the use of clippy viable when working on this project.
Currently you are quite likely to miss any issues you introduce because there's already so many warnings.

If you disagree, feel free to close this.

This was partially autogenerated using cargo clippy --fix, but manually reviewed & cleaned up.
Should hopfully be very easy to review, as nothing really happens.

@coveralls
Copy link

Coverage Status

coverage: 81.386% (-0.07%) from 81.457%
when pulling 3ebf3d6 on cmrschwarz:clippy_fixes
into 95a53a8 on sunng87:master.

@sunng87
Copy link
Owner

sunng87 commented Jul 14, 2024

Thank you! Because our tests are not covered by github check. Could you please also add cargo clippy --all-targets in the github workflow file to ensure we have tests covered?

Copy link
Owner

@sunng87 sunng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge this and add github check myself. Thank you!

@sunng87 sunng87 merged commit 55c2b2e into sunng87:master Jul 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants