Avoid cloning the Render Context #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmrschwarz
force-pushed
the
avoid_context_clone_v2
branch
from
3943117 to
1adbc0a
Compare
|
Awesome! This is great step forward! I will create a benchmark for partials to measure this. |
sunng87
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by your comment in #624 I think I came up with a much better way to fix the problem.
The reason why we couldn't get the correct lifetime is that dev mode dynamically creates new templates during rendering. So I just fixed that problem instead by making dev mode load all templates upfront.
That way we now no longer have to clone the RenderContext 🎉 .
Incidentally this also solves the issue that dev mode would reload a template from disk each time it hits it,
including in some nested
{{#each}}. I think this probably more than outweighs the drawback of having to preload all registered templates. We could optimize this further in the future, though it may even be good enough as is.Resolves #624.