Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate RenderContextInner #662

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

cmrschwarz
Copy link
Contributor

@cmrschwarz cmrschwarz commented Jul 17, 2024

Hey, I realized that there's one last thing I think we could consider before v6.0.

Now that we no longer clone the RenderContext we could get rid of the slightly hacky RenderContextInner
and the whole writing through an Rc idiom associated with it.

I know I initially said that I don't expect any more breaking changes,
but I missed that this narrows the lifetime contract on the public RenderContext type.
This shouldn't really affect anybody ('reg: 'rc is basically assumed everwhere already),
but as a matter of technicality might be semver incompatible.

This should now really be the last breaking change in the indent patch series though :).

@coveralls
Copy link

Coverage Status

coverage: 81.95% (+0.4%) from 81.548%
when pulling 64b709c on cmrschwarz:eliminate_rc_inner
into 080b5e0 on sunng87:master.

Copy link
Owner

@sunng87 sunng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@sunng87 sunng87 merged commit 0af6fdc into sunng87:master Jul 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants