Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
with_indent
function allocates a string to render the content into for every singleindent_aware_write
.It also operates on a per char basis instead of processing full line slices at a time.
This PR fixes this by implementing an improved version that operates directly on the output stream.
In my testing this gives us about a 5 to 15% performance boost 🚀 ,
although the benchmarks are a bit flaky. I also added another benchmark with some
more nested partials than in the others, which benefits the most from this change.