ui: Updater: More verbose when running #388
Draft
+27
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added multiple Params.put() calls throughout the updater process to provide detailed status updates. This includes stages like setting git options, copying update files, performing git cleanup, and checking current branches and commits. These changes improve transparency and tracking of the update process.
Updated several "UpdaterState" messages for consistency and clarity. Moved certain status updates closer to their respective operations to provide real-time feedback. This enhances readability and ensures users receive pertinent updates throughout the process.
Added parameter updates to provide user feedback during the update and check processes. This includes indicating that an update request or a check is being initiated, and specifying that the git cleanup might take a while.
Reorder cloudlog.info entry for SIGUSR1, ensuring parameter update messages are set before logging. Also, make minor capitalization adjustments to UpdaterState messages for consistency.
Changed param assignments in signal handlers to utilize the `self.params` instance variable. This ensures consistency and improves code readability by avoiding reliance on the global `params` object.
sunnyhaibin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help people to feel less frustrated when they tap on "check" and it just goes grey and it just seems like hanging in there...