Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fido PSP FIELDS radio data client #34

Merged
merged 11 commits into from
Mar 10, 2021
Merged

Conversation

samaloney
Copy link
Contributor

@samaloney samaloney commented Apr 4, 2020

It works 🚀

  • Demo
  • Tests
  • Docs
  • Move to radiospectra.net.sources
  • Handle frequncies (the radio data is split into two files to cover lower and higher frequency ranges)
import radiospectra.net
from sunpy.net import Fido, attrs as a
results = Fido.search(a.Time("2019/10/02", "2019/10/05"), a.Instrument('rfs'))
print(results)

Results from 1 Provider:

8 Results from the RFSClient:
     Start Time           End Time      ... Provider   Wavelength [2]
------------------- ------------------- ... -------- -----------------
2019-10-02 00:00:00 2019-10-02 23:59:59 ...     SPDF    10.0 .. 1700.0
2019-10-03 00:00:00 2019-10-03 23:59:59 ...     SPDF    10.0 .. 1700.0
2019-10-04 00:00:00 2019-10-04 23:59:59 ...     SPDF    10.0 .. 1700.0
2019-10-05 00:00:00 2019-10-05 23:59:59 ...     SPDF    10.0 .. 1700.0
2019-10-02 00:00:00 2019-10-02 23:59:59 ...     SPDF 1300.0 .. 19200.0
2019-10-03 00:00:00 2019-10-03 23:59:59 ...     SPDF 1300.0 .. 19200.0
2019-10-04 00:00:00 2019-10-04 23:59:59 ...     SPDF 1300.0 .. 19200.0
2019-10-05 00:00:00 2019-10-05 23:59:59 ...     SPDF 1300.0 .. 19200.0

@pep8speaks
Copy link

pep8speaks commented Apr 4, 2020

Hello @samaloney! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-02-12 16:41:01 UTC

@nabobalis nabobalis marked this pull request as draft October 17, 2020 09:11
@nabobalis nabobalis changed the title WIP: Fido PSP FIELDS radio data client Fido PSP FIELDS radio data client Oct 17, 2020
@nabobalis
Copy link
Contributor

If you have some time, if you could rebase this on top current master.

@samaloney samaloney mentioned this pull request Oct 18, 2020
4 tasks
@samaloney samaloney force-pushed the fido_psp branch 5 times, most recently from 961f860 to 0e30e6a Compare October 19, 2020 08:51
@hayesla
Copy link
Member

hayesla commented Oct 19, 2020

these are great @samaloney ! trying to bring back life to radio spectra!

The only thing is that I don't think that these will work with the updated Fido generic client!(?)

sunpy/sunpy#3768

@samaloney samaloney force-pushed the fido_psp branch 3 times, most recently from 83780c1 to 40a0c97 Compare October 22, 2020 07:06
@samaloney samaloney added this to the 0.2.1 milestone Oct 22, 2020
@samaloney
Copy link
Contributor Author

I think at this stage all the failures are to be expected until new sunpy 2.1 is released and decpenecnes are bumped here.

@samaloney samaloney marked this pull request as ready for review October 22, 2020 07:36
@hayesla
Copy link
Member

hayesla commented Oct 23, 2020

Maybe I'm going mad...

I checked out this branch and then tried to do import radiospectra.net and get

AttributeError: module 'sunpy.net.attrs' has no attribute 'Source'

I'm on sunpy 2.0.3

What am I doing wrong?

@nabobalis
Copy link
Contributor

nabobalis commented Oct 23, 2020

Maybe I'm going mad...

I checked out this branch and then tried to do import radiospectra.net and get

AttributeError: module 'sunpy.net.attrs' has no attribute 'Source'

I'm on sunpy 2.0.3

What am I doing wrong?

Source was moved there in sunpy master but not in 2.0, this PR only works on sunpy master.

@hayesla
Copy link
Member

hayesla commented Oct 23, 2020

oh yeah - thanks!

I should have read Shane's previous comment 🤦 thanks @nabobalis

radiospectra/net/sources/psp.py Outdated Show resolved Hide resolved
radiospectra/net/sources/psp.py Show resolved Hide resolved
@samaloney samaloney force-pushed the fido_psp branch 4 times, most recently from d532195 to 660e0b6 Compare February 13, 2021 08:58
Shane Maloney and others added 7 commits February 13, 2021 13:05
@nabobalis
Copy link
Contributor

You should adjust .gitattributes (see https://github.com/sunpy/sunpy/blob/master/.gitattributes) so that is a binary file: radiospectra/tests/data/BIR_20110607_062400_10.fit

setup.cfg Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
@nabobalis nabobalis modified the milestones: 0.2.1, 0.3.0 Mar 6, 2021
Shane Maloney and others added 3 commits March 10, 2021 16:41
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
@samaloney samaloney merged commit 122b9bf into sunpy:master Mar 10, 2021
@samaloney samaloney mentioned this pull request Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants