Adding colorbar functionality to plot #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder what the return type of the plot method should be the figure, axis or the output from pcolor mesh? what does sunpy do? |
samaloney
reviewed
Nov 2, 2022
Comment on lines
181
to
182
| plt.sca(axes) | ||
| plt.sci(im) |
There was a problem hiding this comment.
So I guess this sets the active axis and active image? I wonder why this is even necessary but I'm not matplotlib expert
There was a problem hiding this comment.
This is how we do it in sunpy core so its good enough for me
nabobalis
force-pushed
the
plotting_fix
branch
from
439fa6c to
3c22237
Compare
nabobalis
force-pushed
the
plotting_fix
branch
from
65e0a50 to
cb89289
Compare
nabobalis
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Fixes #79
now you can do: