Adds ability to plot Pfsspy field lines #12
Conversation
|
What is the output from the new example? |
| from sunkit_pyvista import SunpyPlotter | ||
|
|
||
| ############################################################################### | ||
| # We will firstly use an AIA 193 image from the sunpy sample data as the base image. |
There was a problem hiding this comment.
This will be an issue if the AIA map and the GONG map were not taken at the same time. I will see if I can add a GONG map to the pfsspy sample data that is taken at the same observation date as the AIA map. Lets not block this PR on this point, but we should fix it before releasing the package!
There was a problem hiding this comment.
Oh okay, yes
sunkit_pyvista/plotter.py
Outdated
| tracer = tracing.PythonTracer() | ||
| input_ = pfsspy.Input(gong_map, nrho, rss) | ||
| output_ = pfsspy.pfss(input_) | ||
|
|
||
| seeds = SkyCoord(lon, lat, radius*R_sun, | ||
| frame=gong_map.coordinate_frame) | ||
|
|
||
| field_lines = tracer.trace(seeds, output_) |
There was a problem hiding this comment.
These lines should all go in the example script, and the plot_field_lines method should just take field_lines and **kwargs as input. That way, the user has access to the PFSS solution if they want to trace different lines through it or do other things that aren't plotting the lines.
There was a problem hiding this comment.
yeah this makes more sense, I'll update the PR
The colours have to be added in |
Co-authored-by: David Stansby <dstansby@gmail.com>
|
This looks great! |
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
A rough draft on adding functionality to plot field lines.
Most of the field creation of the lon, lat and and radius values are done in the example file and I'm not sure this is how we want it structured here.
Should we allow
plot_field_linesmethod to accept Skycoord only as an argument and directly plot the field lines instead of creating the Skycoord with thelon,latandrvalues being passed to SkyCood?