Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update field line example #85

Merged
merged 9 commits into from
Jun 20, 2022
Merged

Update field line example #85

merged 9 commits into from
Jun 20, 2022

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Mar 6, 2022 •
edited by nabobalis
Loading

Also:

  • Bumped sunpy to new LTS
  • Tweaked RTD
  • "Fixed" failing test
  • Minor other changes for tox
  • Moved to using actions that openastro provide

@dstansby dstansby added this to the 0.1 milestone Mar 6, 2022
@dstansby dstansby force-pushed the flines branch 2 times, most recently from 5d08b8f to df7f519 Compare March 6, 2022 21:27
@nabobalis nabobalis closed this Jun 20, 2022
@nabobalis nabobalis reopened this Jun 20, 2022
nabobalis
nabobalis reviewed Jun 20, 2022
View reviewed changes
sunkit_pyvista/tests/test_pyvista.py
assert isinstance(plotter.all_meshes['field_lines'][0],
pv.core.composite.MultiBlock)
pv.PolyData)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is bad but for now I will ignore it.

@nabobalis
Copy link
Contributor

I am unsure why RTD isn't reporting. Hopefully with this PR, it will pass on main again.

@nabobalis nabobalis merged commit 06a09e9 into main Jun 20, 2022
@nabobalis nabobalis deleted the flines branch June 20, 2022 22:16
@nabobalis nabobalis added the No Changelog Entry Needed Skip all changelog checks. label Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabobalis nabobalis nabobalis left review comments

Assignees
No one assigned
Labels
No Changelog Entry Needed Skip all changelog checks.
Projects
None yet
Milestone
0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@dstansby @nabobalis