Perform nil check on string fields when packing (google#7719)

Co-authored-by: Derek Bailey <derekbailey@google.com>
sunwen18 · Dec 25, 2022 · c84ae5a · c84ae5a
1 parent d8792cc
commit c84ae5a
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/src/idl_gen_go.cpp b/src/idl_gen_go.cpp
@@ -1054,8 +1054,11 @@ class GoGenerator : public BaseGenerator {
       const std::string offset = field_var + "Offset";
 
       if (IsString(field.value.type)) {
-        code +=
-            "\t" + offset + " := builder.CreateString(t." + field_field + ")\n";
+        code += "\t" + offset + " := flatbuffers.UOffsetT(0)\n";
+        code += "\tif t." + field_field + " != \"\" {\n";
+        code += "\t\t" + offset + " = builder.CreateString(t." + field_field +
+                ")\n";
+        code += "\t}\n";
       } else if (IsVector(field.value.type) &&
                  field.value.type.element == BASE_TYPE_UCHAR &&
                  field.value.type.enum_def == nullptr) {

diff --git a/tests/MyGame/Example/Monster.go b/tests/MyGame/Example/Monster.go
diff --git a/tests/MyGame/Example/Stat.go b/tests/MyGame/Example/Stat.go