Add support for MFA signup and login flow #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelschattgen
force-pushed
the
feature/mfa
branch
from
339f1f7
to
dd5124a
Compare
acupofjose
approved these changes
Jul 23, 2024
|
@michaelschattgen this is an awesome PR - thank you for your efforts! Code / implementation all looks solid to me, really appreciate the comments and clarity. Any chance you'd be willing to include tests too? That's about the only thing I see missing. |
|
Thank you! I expect to add tests somewhere in the upcoming days. 😌 |
|
I've added the tests for both the StatelessClient and the GotrueClient. I've decided to just combine all MFA calls into 1 test since they all overlap, they all rely on a working Enroll, Verify and Challenge. Alongside these complete flow tests I've also added a couple failure tests. Please let me know if this is sufficient! |
acupofjose
approved these changes
Jul 25, 2024
|
Splendid work, seriously. Thanks for being so thorough - Happy to merge this featureset! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This pull request adds support for the multi factor authentication flow. I've tested all the methods through the Example application. Please let me know if I need to add/change anything.