Adjust to a DI structure #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HunteRoi could you look at this? |
HunteRoi
suggested changes
Oct 30, 2022
…need to be called by the developer.
# Conflicts: # Gotrue/Constants.cs # Gotrue/StatelessClient.cs
|
@HunteRoi if this looks good to you - this will be the structure I'll be taking to update the other libraries. (Now tracking at supabase-community/supabase-csharp#35) |
|
Went through it diagonally and it seems good |
This was referenced Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref to #36 and supabase-community/supabase-csharp#23
IGotrueApi,IGotrueClientandIGotrueStatelessClientMicrosoft.Extensions.Hosting.HostBreaking Changes:
StatelessClientis no longer astaticclass but can be used as atransientclass (allows for maintaining api via Interface)Clientrequires callingInstantiateAsyncbut is no longer a singleton.Clientclass were moved toConstantsfor better organization.Big thanks to HunteRoi for his suggestions!