Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update supabase js #327

Merged
merged 7 commits into from
Oct 25, 2022
Merged

Conversation

david-plugge
Copy link
Collaborator

What kind of change does this PR introduce?

Update to supabase-js 2.0.4

What is the current behavior?

We are currently missusing setSession(session) to refresh the session in sveltekit.

What is the new behavior?

Use the new refreshSession() method

@KevM
Copy link

KevM commented Oct 24, 2022

This seems a duplicate of #331

@david-plugge
Copy link
Collaborator Author

This seems a duplicate of #331

No, this PR makes use of the new method refreshSession as described above

@silentworks
Copy link
Contributor

@david-plugge do we need this to be a new release?

@wiesson
Copy link

wiesson commented Oct 25, 2022

Does it make sense to split the PR in

  1. Update supabase-js to most recent version
  2. Switch to refreshSession

So it's more clear, what is going on

This reverts commit b273699.
@silentworks
Copy link
Contributor

Does it make sense to split the PR in

1. Update supabase-js to most recent version

2. Switch to refreshSession

So it's more clear, what is going on

Its only a small change but we can write this in the changeset.

@silentworks silentworks merged commit 2fda843 into supabase:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants