Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move @types/cookie to main dependencies #781

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rbutera
Copy link

@rbutera rbutera commented May 17, 2024

What kind of change does this PR introduce?

Bug fix / Dependencies update

What is the current behavior?

Currently @types/cookie is listed as a dev dependency only which results in projects that use @supabase/ssr running into difficult-to-debug @typescript-eslint no-unsafe-argument errors. See supabase/auth issue supabase/ssr#53 where this behaviour is reported and documented.

The change in this PR satisfies the solution proposed in the above PR.

What is the new behavior?

@types/cookie is added to dependencies so that the CookieOptions type can be properly inferred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant