Merge pull request #24 from duncanhealy/fix/types

fix tsc output for types
supabase · Nov 15, 2020 · bad9993 · bad9993
2 parents 18859b3 + ec576fd
commit bad9993
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -33,6 +33,7 @@
   },
   "devDependencies": {
     "@types/jest": "^26.0.13",
+    "@types/node": "^14.14.7",
     "@types/node-fetch": "^2.5.7",
     "jest": "^26.4.1",
     "npm-run-all": "^4.1.5",

diff --git a/src/GoTrueClient.ts b/src/GoTrueClient.ts
@@ -7,7 +7,7 @@ const DEFAULT_OPTIONS = {
   url: GOTRUE_URL,
   autoRefreshToken: true,
   persistSession: true,
-  localStorage: global.localStorage,
+  localStorage: globalThis.localStorage,
   detectSessionInUrl: true,
   headers: DEFAULT_HEADERS,
 }

diff --git a/src/lib/helpers.ts b/src/lib/helpers.ts
@@ -23,7 +23,7 @@ export class LocalStorage implements Storage {
   [name: string]: any
   length!: number
   constructor(localStorage: Storage) {
-    this.localStorage = localStorage || global.localStorage
+    this.localStorage = localStorage || globalThis.localStorage
   }
   clear(): void {
     return this.localStorage.clear()

diff --git a/test/__snapshots__/client.test.ts.snap b/test/__snapshots__/client.test.ts.snap
@@ -27,6 +27,7 @@ Object {
   "created_at": Any<String>,
   "email": "fake@email.com",
   "id": Any<String>,
+  "last_sign_in_at": Any<String>,
   "role": "",
   "updated_at": Any<String>,
   "user_metadata": Object {
@@ -45,6 +46,7 @@ Object {
   "created_at": Any<String>,
   "email": "fake@email.com",
   "id": Any<String>,
+  "last_sign_in_at": Any<String>,
   "role": "",
   "updated_at": Any<String>,
   "user_metadata": Object {

diff --git a/test/client.test.ts b/test/client.test.ts
@@ -81,6 +81,7 @@ test('Update user', async () => {
     id: expect.any(String),
     aud: expect.any(String),
     updated_at: expect.any(String),
+    last_sign_in_at: expect.any(String),
     confirmed_at: expect.any(String),
     created_at: expect.any(String),
     user_metadata: {
@@ -95,6 +96,7 @@ test('Get user after updating', async () => {
     id: expect.any(String),
     aud: expect.any(String),
     updated_at: expect.any(String),
+    last_sign_in_at: expect.any(String),
     confirmed_at: expect.any(String),
     created_at: expect.any(String),
     user_metadata: {