-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs #42
Fix bugs #42
Conversation
pr: @thorwebdev | @soedirgo TBH the "globalThis" is a new one to me. #38 links to this: https://codesandbox.io/s/github/supabase/supabase/tree/master/examples/nextjs-todo-list I suspect if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we can polyfill localStorage, we probably won't need to polyfill globalThis since we can just use localStorage
without fully qualifying it. But I can't find an isomorphic localStorage solution :/
There's node-localstorage but it's possible that the context is a browser that doesn't support localStorage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL 🤯
LGTM
🎉 This PR is included in version 1.10.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What kind of change does this PR introduce?