Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable passing scopes to provider #66

Merged
merged 7 commits into from
Mar 10, 2021
Merged

Conversation

mateomorris
Copy link
Contributor

What kind of change does this PR introduce?

Allows a user to request scopes while signing up/in with an OAuth provider, and returns provider_token which allows access to the provider's API.

const { user, session, error } = await supabase.auth.signIn({
  provider: 'github'
}, {
  scopes: 'repo notifications'
})

@kiwicopple
Copy link
Member

Wow, nice @mateomorris @Beamanator 💯

image

Not sure what's going on with this test case. Perhaps some settings changed on GoTrue? I'll check with Ant, but otherwise this looks great

@mateomorris
Copy link
Contributor Author

Thanks @kiwicopple! Not sure what's going on there; I'll check too

@awalias
Copy link
Member

awalias commented Mar 10, 2021

just needs 98b4a4f

@mateomorris
Copy link
Contributor Author

mateomorris commented Mar 10, 2021

and docs are incoming: supabase/supabase#849

@kiwicopple
Copy link
Member

OK great everyone. This is an amazing PR - new functionality, updates to the server, updates to the client, updates to the docs

Thank you for all the help @mateomorris @Beamanator. I'll merge this now, once it's released I'll add it to supabase-js, then merge the Docs PR.

Also do you have twitter handles? I can send out a tweet so people know that it exists

@kiwicopple kiwicopple merged commit 3999a6d into supabase:master Mar 10, 2021
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mateomorris
Copy link
Contributor Author

Happy to help! Thank you guys for being so responsive; hope this opens Supabase up to more people. We're @ _mateomorris & Beamanator1

dshukertjr pushed a commit to dshukertjr/gotrue-js that referenced this pull request Jun 26, 2021
dshukertjr pushed a commit to dshukertjr/gotrue-js that referenced this pull request Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants