Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return warning if persistSession is true with no storage option #697

Merged
merged 1 commit into from
May 31, 2023
Merged

fix: return warning if persistSession is true with no storage option #697

merged 1 commit into from
May 31, 2023

Conversation

kangmingtay
Copy link
Member

What kind of change does this PR introduce?

@kangmingtay kangmingtay requested review from hf and J0 May 31, 2023 08:51
@kangmingtay kangmingtay changed the title fix: return warning if persisSession is true with no storage option fix: return warning if persistSession is true with no storage option May 31, 2023
@kangmingtay kangmingtay merged commit 4664066 into master May 31, 2023
@kangmingtay kangmingtay deleted the km/fix-persist-session branch May 31, 2023 15:29
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.28.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iwasrobbed iwasrobbed mentioned this pull request Jun 13, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J0 J0 J0 approved these changes

@hf hf Awaiting requested review from hf

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kangmingtay @J0