Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add build step #906

Merged
merged 1 commit into from
Jun 5, 2024
Merged

ci: add build step #906

merged 1 commit into from
Jun 5, 2024

Conversation

hf
Copy link
Contributor

@hf hf commented May 12, 2024

Build was missing for some reason. 😱

@hf hf force-pushed the hf/ci-build branch 2 times, most recently from e38b60f to 161478a Compare May 12, 2024 16:50
Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like npm ci, as a standardized command, primarily installs from package-lock.json and does not run build

Tests do not run the build step either

Thanks for the catch!

@kangmingtay kangmingtay merged commit 5bda912 into master Jun 5, 2024
3 checks passed
@kangmingtay kangmingtay deleted the hf/ci-build branch June 5, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants