feat: add getUserByEmail function to GoTrueAdminApi #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
commented
Aug 29, 2024
| }, | ||
| }) | ||
|
|
||
| const users = response?.data?.user?.users || [] |
There was a problem hiding this comment.
Changed this to a nullish check.
J0
commented
Aug 29, 2024
| return { data: { user: users[0] }, error: null } | ||
| } | ||
|
|
||
| throw new UserNotFoundError() |
There was a problem hiding this comment.
Moved the initialization of the custom error to errors.ts for easier tracking and re-use
J0
commented
Aug 29, 2024
| headers: this.headers, | ||
| xform: _userResponse, | ||
| query: { | ||
| filter: email, |
There was a problem hiding this comment.
Dropped the URL Encode on email as _request seems to do URLEncoding here
Passing in an encoded email seems to lead to double encoding for me locally
J0
commented
Aug 29, 2024
| @@ -915,7 +921,7 @@ export type AuthMFAEnrollResponse = | |||
| friendly_name?: string | |||
|
|
|||
| /** Phone number of the MFA factor in E.164 format. Used to send messages */ | |||
| phone: string | |||
| phone: string | |||
There was a problem hiding this comment.
Suggested change
| phone: string | |
| phone: string |
|
Closing for now, see rationale on supabase/auth#880 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Branched off of #933 and added a few suggestions. Please review alongside #933 as there is more context there
Original Auth issue: supabase/auth#880
Tested locally