Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve mfa.enroll return types #956

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix: improve mfa.enroll return types #956

merged 1 commit into from
Sep 17, 2024

Commits on Sep 16, 2024

  1. fix: improve mfa.enroll return types 

    Use TypeScript's operator overloading to return
- TOTP data when `mfa.enroll` was passed `factorType: 'totp'`,
- phone data when `mfa.enroll` was passed `factorType: 'phone'`.

This fixes a breaking change in the types in
b957c30.
    @aloisklink
    aloisklink committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    01ba4ff View commit details
    Browse the repository at this point in the history