Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add MFA for WebAuthn bindings #960

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add MFA for WebAuthn bindings #960

wants to merge 1 commit into from

Conversation

J0
Copy link
Contributor

@J0 J0 commented Sep 19, 2024

What kind of change does this PR introduce?

We introduce bindings for MFA (WebAuthn) which consists of the following:

  1. enroll()
    a. Single Step - enroll({factorType: 'webauthn'})
    b. Multi-Step - enroll(factorType: 'webauthn, webAuthn{...})
  2. challenge() -
  3. verify()
    a. Single Step - verify({factorType: 'webauthn'})
    b. Multi-Step - verify({factorType: 'webauthn', webAuthn{..}})

src/lib/types.ts Outdated Show resolved Hide resolved
src/GoTrueClient.ts Outdated Show resolved Hide resolved
src/lib/types.ts Show resolved Hide resolved
src/lib/types.ts Outdated Show resolved Hide resolved
src/lib/helpers.ts Show resolved Hide resolved
@J0 J0 marked this pull request as ready for review October 2, 2024 14:18
src/lib/types.ts Outdated Show resolved Hide resolved
src/lib/types.ts Outdated Show resolved Hide resolved
src/GoTrueClient.ts Show resolved Hide resolved
src/lib/helpers.ts Show resolved Hide resolved
src/lib/helpers.ts Outdated Show resolved Hide resolved
src/lib/helpers.ts Outdated Show resolved Hide resolved
src/lib/helpers.ts Outdated Show resolved Hide resolved
src/lib/helpers.ts Outdated Show resolved Hide resolved
src/lib/helpers.ts Outdated Show resolved Hide resolved
src/lib/helpers.ts Outdated Show resolved Hide resolved
src/lib/helpers.ts Outdated Show resolved Hide resolved
src/lib/helpers.ts Outdated Show resolved Hide resolved
src/lib/helpers.ts Outdated Show resolved Hide resolved
src/lib/types.ts Outdated Show resolved Hide resolved
src/lib/types.ts Outdated Show resolved Hide resolved

export type MFAVerifySingleStepWebAuthnParams = {
factorId: string
challengeId: string
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
challengeId: string
challengeId?: string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants