-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sign_in_with_id_token method #548
Conversation
🧙 Sourcery has finished reviewing your pull request! Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Please test against an auth service before merging
Tested with Google for web sign in button and its working. Video attached showing this working. Supabase.Sign.In.With.Id.Token.mp4 |
What kind of change does this PR introduce?
Add the
sign_in_with_id_token
method for Google and others one tap integration.What is the current behavior?
There is no
sign_in_with_id_token
methodWhat is the new behavior?
There is now a
sign_in_with_id_token
methodAdditional context
Add any other context or screenshots.