Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sign_in_with_id_token method #548

Merged
merged 2 commits into from
Jul 17, 2024
Merged

add sign_in_with_id_token method #548

merged 2 commits into from
Jul 17, 2024

Conversation

silentworks
Copy link
Contributor

What kind of change does this PR introduce?

Add the sign_in_with_id_token method for Google and others one tap integration.

What is the current behavior?

There is no sign_in_with_id_token method

What is the new behavior?

There is now a sign_in_with_id_token method

Additional context

Add any other context or screenshots.

@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Jul 17, 2024 •
edited
Loading

🧙 Sourcery has finished reviewing your pull request!

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

sourcery-ai[bot]
sourcery-ai bot reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@silentworks silentworks linked an issue Jul 17, 2024 that may be closed by this pull request
Add sign in with id token #547
Closed
J0
J0 reviewed Jul 17, 2024
View reviewed changes
supabase_auth/types.py Outdated Show resolved Hide resolved
J0
J0 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Please test against an auth service before merging

@silentworks
Copy link
Contributor Author

Tested with Google for web sign in button and its working. Video attached showing this working.

Supabase.Sign.In.With.Id.Token.mp4

@silentworks silentworks merged commit b7e2c2c into main Jul 17, 2024
7 checks passed
@silentworks silentworks deleted the silentworks/sign_in_id_token branch July 17, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai Sourcery AI sourcery-ai left review comments

@J0 J0 J0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add sign in with id token
2 participants
@silentworks @J0