feat: add pkce to email_change routes #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 14, 2023 18:21
|
Leaving this as draft, will merge after deploy |
|
🎉 This PR is included in version 2.61.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
J0
added a commit
to supabase/auth-js
that referenced
this pull request
Sep 4, 2023
## What kind of change does this PR introduce? To be merged only when the corresponding server side PR has landed: supabase/auth#1082 --------- Co-authored-by: joel@joellee.org <joel@joellee.org>
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? Add PKCE to email Change routes ## What is the current behavior? No PKCE on email change routes ## What is the new behavior? PKCE on email change routes ## Additional context There's an additional AMR claim known as `email_change` I'm not sure whether we want to have a special claim for this given that `email_change` is not typically classed as a login method. The other option would be to use the Magic Link AMR claim instead. Let me know if anyone has a preference here. Should be tested with: https://github.com/supabase/gotrue-js/pull/661/files TODOs: - [x] Tests need to be written for the PKCE path --------- Co-authored-by: joel@joellee.org <joel@joellee.org>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? Add PKCE to email Change routes ## What is the current behavior? No PKCE on email change routes ## What is the new behavior? PKCE on email change routes ## Additional context There's an additional AMR claim known as `email_change` I'm not sure whether we want to have a special claim for this given that `email_change` is not typically classed as a login method. The other option would be to use the Magic Link AMR claim instead. Let me know if anyone has a preference here. Should be tested with: https://github.com/supabase/gotrue-js/pull/661/files TODOs: - [x] Tests need to be written for the PKCE path --------- Co-authored-by: joel@joellee.org <joel@joellee.org>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
## What kind of change does this PR introduce? Add PKCE to email Change routes ## What is the current behavior? No PKCE on email change routes ## What is the new behavior? PKCE on email change routes ## Additional context There's an additional AMR claim known as `email_change` I'm not sure whether we want to have a special claim for this given that `email_change` is not typically classed as a login method. The other option would be to use the Magic Link AMR claim instead. Let me know if anyone has a preference here. Should be tested with: https://github.com/supabase/gotrue-js/pull/661/files TODOs: - [x] Tests need to be written for the PKCE path --------- Co-authored-by: joel@joellee.org <joel@joellee.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Add PKCE to email Change routes
What is the current behavior?
No PKCE on email change routes
What is the new behavior?
PKCE on email change routes
Additional context
There's an additional AMR claim known as
email_changeI'm not sure whether we want to have a special claim for this given thatemail_changeis not typically classed as a login method. The other option would be to use the Magic Link AMR claim instead. Let me know if anyone has a preference here.Should be tested with: https://github.com/supabase/gotrue-js/pull/661/files
TODOs: