feat: add support for Twilio Verify #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
June 2, 2023 13:29
2 tasks
added 7 commits
June 12, 2023 12:46
kangmingtay
reviewed
Jun 13, 2023
hf
reviewed
Jun 13, 2023
Co-authored-by: Stojan Dimitrovski <sdimitrovski@gmail.com>
…o j0/add_twilio_verify
J0
commented
Jun 14, 2023
added 7 commits
June 16, 2023 16:15
hf
reviewed
Jun 19, 2023
added 7 commits
June 20, 2023 15:53
1 task
kangmingtay
approved these changes
Jun 22, 2023
hf
approved these changes
Jun 22, 2023
|
🎉 This PR is included in version 2.76.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? Aims to add Twilio Verify Support. Twilio Verify is implemented as a separate provider. Only one of Twilio Verify or Twilio Programmable messaging an be selected. At this time, we only support the use of the `whatsapp` and `sms` channels with Twilio Verify. This will affect the: 1. Signup flow 2. Verification flow (sms and phone_change) 3. Resend The token is still generated, but not used in the Twilio Verify flow. It is used as a placeholder so as to try to ensure that to the OTP returned by the Verify service can only be used with the corresponding flow it was generated for. ## What is the current behaviour? We support programmable messaging. ## What is the new behaviour? Developer can toggle between using Twilio Programmable Messaging on all flows or Twilio Verify on all flows. ## Additional context Manual tests: Probably need to be conducted on both Phone Change and SMS OTP Verification: - [x] Existing Programmable Messaging (SMS/WhatsApp) (Signup/Verify/PhoneChange) - [x] Twilio Verify(SMS/WhatsApp) - [ ] Update Frontend to include Twilio Verify Admin methods shouldn't need to be updated to send to Twilio Verify since admin methods don't require confirmation --------- Co-authored-by: joel@joellee.org <joel@joellee.org> Co-authored-by: Stojan Dimitrovski <sdimitrovski@gmail.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? Aims to add Twilio Verify Support. Twilio Verify is implemented as a separate provider. Only one of Twilio Verify or Twilio Programmable messaging an be selected. At this time, we only support the use of the `whatsapp` and `sms` channels with Twilio Verify. This will affect the: 1. Signup flow 2. Verification flow (sms and phone_change) 3. Resend The token is still generated, but not used in the Twilio Verify flow. It is used as a placeholder so as to try to ensure that to the OTP returned by the Verify service can only be used with the corresponding flow it was generated for. ## What is the current behaviour? We support programmable messaging. ## What is the new behaviour? Developer can toggle between using Twilio Programmable Messaging on all flows or Twilio Verify on all flows. ## Additional context Manual tests: Probably need to be conducted on both Phone Change and SMS OTP Verification: - [x] Existing Programmable Messaging (SMS/WhatsApp) (Signup/Verify/PhoneChange) - [x] Twilio Verify(SMS/WhatsApp) - [ ] Update Frontend to include Twilio Verify Admin methods shouldn't need to be updated to send to Twilio Verify since admin methods don't require confirmation --------- Co-authored-by: joel@joellee.org <joel@joellee.org> Co-authored-by: Stojan Dimitrovski <sdimitrovski@gmail.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
## What kind of change does this PR introduce? Aims to add Twilio Verify Support. Twilio Verify is implemented as a separate provider. Only one of Twilio Verify or Twilio Programmable messaging an be selected. At this time, we only support the use of the `whatsapp` and `sms` channels with Twilio Verify. This will affect the: 1. Signup flow 2. Verification flow (sms and phone_change) 3. Resend The token is still generated, but not used in the Twilio Verify flow. It is used as a placeholder so as to try to ensure that to the OTP returned by the Verify service can only be used with the corresponding flow it was generated for. ## What is the current behaviour? We support programmable messaging. ## What is the new behaviour? Developer can toggle between using Twilio Programmable Messaging on all flows or Twilio Verify on all flows. ## Additional context Manual tests: Probably need to be conducted on both Phone Change and SMS OTP Verification: - [x] Existing Programmable Messaging (SMS/WhatsApp) (Signup/Verify/PhoneChange) - [x] Twilio Verify(SMS/WhatsApp) - [ ] Update Frontend to include Twilio Verify Admin methods shouldn't need to be updated to send to Twilio Verify since admin methods don't require confirmation --------- Co-authored-by: joel@joellee.org <joel@joellee.org> Co-authored-by: Stojan Dimitrovski <sdimitrovski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Aims to add Twilio Verify Support. Twilio Verify is implemented as a separate provider. Only one of Twilio Verify or Twilio Programmable messaging an be selected. At this time, we only support the use of the
whatsappandsmschannels with Twilio Verify.This will affect the:
The token is still generated, but not used in the Twilio Verify flow. It is used as a placeholder so as to try to ensure that to the OTP returned by the Verify service can only be used with the corresponding flow it was generated for.
What is the current behaviour?
We support programmable messaging.
What is the new behaviour?
Developer can toggle between using Twilio Programmable Messaging on all flows or Twilio Verify on all flows.
Additional context
Manual tests:
Probably need to be conducted on both Phone Change and SMS OTP Verification:
Admin methods shouldn't need to be updated to send to Twilio Verify since admin methods don't require confirmation