Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix flaky Google ID token test #1134

Merged
merged 1 commit into from
Jun 13, 2023
Merged

tests: fix flaky Google ID token test #1134

merged 1 commit into from
Jun 13, 2023

Conversation

hf
Copy link
Contributor

@hf hf commented Jun 13, 2023

Google seem to rotate their OIDC JWKS keys regularly, which made the tests fail. This time the verifier is overridden and uses a static key at the time of generating of the ID token.

@hf hf requested a review from a team as a code owner June 13, 2023 12:32
@hf hf force-pushed the hf/fix-flaky-oidc-test branch 2 times, most recently from a00d47f to 52e0263 Compare June 13, 2023 12:41
@hf hf merged commit 8eaba35 into master Jun 13, 2023
@hf hf deleted the hf/fix-flaky-oidc-test branch June 13, 2023 13:18
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.71.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
Google seem to rotate their OIDC JWKS keys regularly, which made the
tests fail. This time the verifier is overridden and uses a static key
at the time of generating of the ID token.
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
Google seem to rotate their OIDC JWKS keys regularly, which made the
tests fail. This time the verifier is overridden and uses a static key
at the time of generating of the ID token.
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
Google seem to rotate their OIDC JWKS keys regularly, which made the
tests fail. This time the verifier is overridden and uses a static key
at the time of generating of the ID token.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants