feat: remove SafeRoundTripper and allow private-IP HTTP connections
#1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf
force-pushed
the
hf/remove-safe-round-tripper
branch
from
071ae1c
to
cc01c53
Compare
|
Looks like the test is failing because it's still referencing a variable that was removed in this PR. |
hf
force-pushed
the
hf/remove-safe-round-tripper
branch
from
cc01c53
to
08dece3
Compare
hf
force-pushed
the
hf/remove-safe-round-tripper
branch
from
08dece3
to
f1e9be7
Compare
|
@hf fwiw, i dont think this will resolve the issue because we use netlify's mailme under the hood which imports the netlify http commons package: https://github.com/netlify/mailme/blob/876c043aa349526e4372914d5ee416ec1de242f1/mailme.go#L120 |
|
also i think we should update the description in the PR and unlink the issue to avoid confusion |
kangmingtay
approved these changes
Jun 28, 2023
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
…supabase#1152) Removes `SafeRoundTripper` which was a HTTP `RoundTripper` which did not allow establishing HTTP connections to servers listening on private IP addresses. This is probably inherited from the Netlify codebase, and was added as a safeguard to avoid cyclic requests with their hooks implementation which is not used by Supabase. Why it's absolutely normal to expect connections to private IP addresses: - Running GoTrue in Kuberenetes, AWS ECS, or other places. - Local development with Docker, which loves to create virtual private networks inside containers all the time. - Caches inside VPCs. - Rendering templates served only within the VPC and not those that are publicly available.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
…supabase#1152) Removes `SafeRoundTripper` which was a HTTP `RoundTripper` which did not allow establishing HTTP connections to servers listening on private IP addresses. This is probably inherited from the Netlify codebase, and was added as a safeguard to avoid cyclic requests with their hooks implementation which is not used by Supabase. Why it's absolutely normal to expect connections to private IP addresses: - Running GoTrue in Kuberenetes, AWS ECS, or other places. - Local development with Docker, which loves to create virtual private networks inside containers all the time. - Caches inside VPCs. - Rendering templates served only within the VPC and not those that are publicly available.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
…supabase#1152) Removes `SafeRoundTripper` which was a HTTP `RoundTripper` which did not allow establishing HTTP connections to servers listening on private IP addresses. This is probably inherited from the Netlify codebase, and was added as a safeguard to avoid cyclic requests with their hooks implementation which is not used by Supabase. Why it's absolutely normal to expect connections to private IP addresses: - Running GoTrue in Kuberenetes, AWS ECS, or other places. - Local development with Docker, which loves to create virtual private networks inside containers all the time. - Caches inside VPCs. - Rendering templates served only within the VPC and not those that are publicly available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
SafeRoundTripperwhich was a HTTPRoundTripperwhich did not allow establishing HTTP connections to servers listening on private IP addresses.This is probably inherited from the Netlify codebase, and was added as a safeguard to avoid cyclic requests with their hooks implementation which is not used by Supabase.
Why it's absolutely normal to expect connections to private IP addresses: