Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: require different passwords on update #1163

Merged
merged 3 commits into from
Jul 4, 2023
Merged

feat: require different passwords on update #1163

merged 3 commits into from
Jul 4, 2023

Conversation

hf
Copy link
Contributor

@hf hf commented Jul 3, 2023

When the user updates their password, the new and old passwords must be different. When an admin does it, this is not checked.

@hf hf requested a review from a team as a code owner July 3, 2023 14:02
J0
J0 approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, perhaps when we have more checks we can shove all the checks (e.g. min length, max length, diff password) into a function

kangmingtay
kangmingtay approved these changes Jul 3, 2023
View reviewed changes
internal/api/user.go Outdated Show resolved Hide resolved
@notion-workspace
Copy link

Microtask: Enforce that a password change uses a different password

2 similar comments
@notion-workspace
Copy link

Microtask: Enforce that a password change uses a different password

@notion-workspace
Copy link

Microtask: Enforce that a password change uses a different password

@hf hf merged commit 154dd91 into master Jul 4, 2023
@hf hf deleted the hf/require-different-password branch July 4, 2023 12:24
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

🎉 This PR is included in version 2.80.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
@hf
feat: require different passwords on update (supabase#1163)
003011b 
When the user updates their password, the new and old passwords must be
different. When an admin does it, this is not checked.
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
@hf @LashaJini
feat: require different passwords on update (supabase#1163)
6b738bb 
When the user updates their password, the new and old passwords must be
different. When an admin does it, this is not checked.
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
@hf @LashaJini
feat: require different passwords on update (supabase#1163)
1047897 
When the user updates their password, the new and old passwords must be
different. When an admin does it, this is not checked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangmingtay kangmingtay kangmingtay approved these changes

@J0 J0 J0 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hf @J0 @kangmingtay