-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support message IDs for Twilio Whatsapp #1203
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf
reviewed
Aug 1, 2023
kangmingtay
reviewed
Aug 1, 2023
kangmingtay
reviewed
Aug 2, 2023
kangmingtay
reviewed
Aug 2, 2023
kangmingtay
approved these changes
Aug 2, 2023
🎉 This PR is included in version 2.90.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
Support the use of Message IDs for Twilio Programmable Messaging on the WhatsApp channel. Arising from a customer request during their launch. The`whatsapp:` channel currently only works when using a phone number in the Message Service ID field. It was assumed that developers would only wish to use `whatsapp` channel with a phone number. However, customers may wish to use [Geomatch](https://support.twilio.com/hc/en-us/articles/223181268-What-is-Geomatch-and-how-does-it-work-) in order to use both SMS and WhatsApp channels. When using Geomatch, Twilio will select the best suited number within the Sender pool of the Message Service and use that as the sender. For instance, if sending to the UK and there is a UK number Twilio and a German number will likely the UK number over the German number. As Geomatch only works with Message IDs we need to add support for using MessageIDs on the `whatsapp` channel on Programmable Messaging. Not needed for Twilio Verify as Twilio Verify does not require the channel to be prefixed before a phone number. --------- Co-authored-by: joel@joellee.org <joel@joellee.org>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
Support the use of Message IDs for Twilio Programmable Messaging on the WhatsApp channel. Arising from a customer request during their launch. The`whatsapp:` channel currently only works when using a phone number in the Message Service ID field. It was assumed that developers would only wish to use `whatsapp` channel with a phone number. However, customers may wish to use [Geomatch](https://support.twilio.com/hc/en-us/articles/223181268-What-is-Geomatch-and-how-does-it-work-) in order to use both SMS and WhatsApp channels. When using Geomatch, Twilio will select the best suited number within the Sender pool of the Message Service and use that as the sender. For instance, if sending to the UK and there is a UK number Twilio and a German number will likely the UK number over the German number. As Geomatch only works with Message IDs we need to add support for using MessageIDs on the `whatsapp` channel on Programmable Messaging. Not needed for Twilio Verify as Twilio Verify does not require the channel to be prefixed before a phone number. --------- Co-authored-by: joel@joellee.org <joel@joellee.org>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
Support the use of Message IDs for Twilio Programmable Messaging on the WhatsApp channel. Arising from a customer request during their launch. The`whatsapp:` channel currently only works when using a phone number in the Message Service ID field. It was assumed that developers would only wish to use `whatsapp` channel with a phone number. However, customers may wish to use [Geomatch](https://support.twilio.com/hc/en-us/articles/223181268-What-is-Geomatch-and-how-does-it-work-) in order to use both SMS and WhatsApp channels. When using Geomatch, Twilio will select the best suited number within the Sender pool of the Message Service and use that as the sender. For instance, if sending to the UK and there is a UK number Twilio and a German number will likely the UK number over the German number. As Geomatch only works with Message IDs we need to add support for using MessageIDs on the `whatsapp` channel on Programmable Messaging. Not needed for Twilio Verify as Twilio Verify does not require the channel to be prefixed before a phone number. --------- Co-authored-by: joel@joellee.org <joel@joellee.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the use of Message IDs for Twilio Programmable Messaging on the WhatsApp channel. Arising from a customer request during their launch.
The
whatsapp:
channel currently only works when using a phone number in the Message Service ID field. It was assumed that developers would only wish to usewhatsapp
channel with a phone number.However, customers may wish to use Geomatch in order to use both SMS and WhatsApp channels. When using Geomatch, Twilio will select the best suited number within the Sender pool of the Message Service and use that as the sender. For instance, if sending to the UK and there is a UK number Twilio and a German number will likely the UK number over the German number.
As Geomatch only works with Message IDs we need to add support for using MessageIDs on the
whatsapp
channel on Programmable Messaging.Not needed for Twilio Verify as Twilio Verify does not require the channel to be prefixed before a phone number.