-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new Linkedin OIDC due to deprecated scopes for new linkedin applications #1248
Conversation
I could also see updating the existing Linkedin provider to default with the original r_emailaddress and r_lightprofile scopes, while having the option to use new scopes. |
Thanks for being the one to tackle this finally! I think this is the PR from the original LinkedIn integration if it helps at all / if you want to add tests. |
Hey @josmo, thanks for your contribution - just wanted to let you know that this is on the auth team's radar but we're currently quite tight on bandwidth so it might take a week for this to be reviewed. I've tested the happy path locally and it seems to work but right now, i'm looking at how we can support both the old and new implementation in a way that's not confusing for our users on the hosted platform. It would really help if you know about the following:
|
@alexcraig043 I'll take a look and see if I get some time to add tests :)
@kangmingtay No worries on timing and totally get wanting something that's not confusing - in terms of questions
|
json convention fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @josmo, thanks for helping to add the new linkedin provider, we'll need some time to roll this out to the platform so that existing apps can continue to work with the old linkedin API
🎉 This PR is included in version 2.97.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Thanks for committing this change! I'm currently getting
when I try to call
Is "linkedin_oidc" the correct provider to use? I updated my supabase-js package, but is there anything else I have to update? |
@alexcraig043 we haven't deployed this to the hosted platform yet but we're planning to do so in the next week. There are bunch of backward compatibility checks to make sure that we don't break existing users using the old linkedin API. If you need this urgently, please reach out via https://supabase.com/dashboard/support/new. |
… applications (supabase#1248) ## What kind of change does this PR introduce? This PR introduces a new linkedin provider to address issues related to the current LinkedIn provider no longer being available for new applications. ## What is the current behavior? LinkedIn applications created after 1st of August experience difficulties while attempting to log in with GoTrue due to incorrect scope requests. Relevant issue: supabase#1216 (comment) Relevant initial fix however would lead to breaking existing apps - supabase#1232 ## What is the new behavior? This PR aims to rectify the issue by adding a new provider with the updated OAuth scopes. Specifically, the scopes openid, email, and profile will be utilized. Additionally, the method of collecting profile information is updated, employing the /v2/userinfo API endpoint. Visual changes: No visual changes. ## Additional context I've taken the initial updates from PR supabase#1232 into the new providers while also adding the relevant settings and provider implementations. I don't know much in terms of this library so would love to get additional feedback. I validated that the - http://localhost:9999/authorize?provider=linkedin-oidc workflow worked locally and had the relevant information in the Claim --------- Co-authored-by: Kang Ming <kang.ming1996@gmail.com>
… applications (supabase#1248) ## What kind of change does this PR introduce? This PR introduces a new linkedin provider to address issues related to the current LinkedIn provider no longer being available for new applications. ## What is the current behavior? LinkedIn applications created after 1st of August experience difficulties while attempting to log in with GoTrue due to incorrect scope requests. Relevant issue: supabase#1216 (comment) Relevant initial fix however would lead to breaking existing apps - supabase#1232 ## What is the new behavior? This PR aims to rectify the issue by adding a new provider with the updated OAuth scopes. Specifically, the scopes openid, email, and profile will be utilized. Additionally, the method of collecting profile information is updated, employing the /v2/userinfo API endpoint. Visual changes: No visual changes. ## Additional context I've taken the initial updates from PR supabase#1232 into the new providers while also adding the relevant settings and provider implementations. I don't know much in terms of this library so would love to get additional feedback. I validated that the - http://localhost:9999/authorize?provider=linkedin-oidc workflow worked locally and had the relevant information in the Claim --------- Co-authored-by: Kang Ming <kang.ming1996@gmail.com>
… applications (supabase#1248) ## What kind of change does this PR introduce? This PR introduces a new linkedin provider to address issues related to the current LinkedIn provider no longer being available for new applications. ## What is the current behavior? LinkedIn applications created after 1st of August experience difficulties while attempting to log in with GoTrue due to incorrect scope requests. Relevant issue: supabase#1216 (comment) Relevant initial fix however would lead to breaking existing apps - supabase#1232 ## What is the new behavior? This PR aims to rectify the issue by adding a new provider with the updated OAuth scopes. Specifically, the scopes openid, email, and profile will be utilized. Additionally, the method of collecting profile information is updated, employing the /v2/userinfo API endpoint. Visual changes: No visual changes. ## Additional context I've taken the initial updates from PR supabase#1232 into the new providers while also adding the relevant settings and provider implementations. I don't know much in terms of this library so would love to get additional feedback. I validated that the - http://localhost:9999/authorize?provider=linkedin-oidc workflow worked locally and had the relevant information in the Claim --------- Co-authored-by: Kang Ming <kang.ming1996@gmail.com>
What kind of change does this PR introduce?
This PR introduces a new linkedin provider to address issues related to the current LinkedIn provider no longer being available for new applications.
What is the current behavior?
LinkedIn applications created after 1st of August experience difficulties while attempting to log in with GoTrue due to incorrect scope requests.
Relevant issue: #1216 (comment)
Relevant initial fix however would lead to breaking existing apps - #1232
What is the new behavior?
This PR aims to rectify the issue by adding a new provider with the updated OAuth scopes. Specifically, the scopes openid, email, and profile will be utilized. Additionally, the method of collecting profile information is updated, employing the /v2/userinfo API endpoint.
Visual changes: No visual changes.
Additional context
I've taken the initial updates from PR #1232 into the new providers while also adding the relevant settings and provider implementations. I don't know much in terms of this library so would love to get additional feedback.
I validated that the - http://localhost:9999/authorize?provider=linkedin-oidc workflow worked locally and had the relevant information in the Claim