Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: take into account test otp for twilio verify #1255

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

J0
Copy link
Contributor

@J0 J0 commented Sep 26, 2023

What kind of change does this PR introduce?

see title, aims to address #1252 and supabase/auth-js#787

TODOs:

  • conduct an end to end test of the PR

@J0 J0 marked this pull request as ready for review September 29, 2023 08:25
@J0 J0 requested a review from a team as a code owner September 29, 2023 08:25
internal/api/verify.go Outdated Show resolved Hide resolved
@J0 J0 merged commit 18b4291 into master Sep 29, 2023
@J0 J0 deleted the j0/add_test_otp_twilio_verify branch September 29, 2023 12:17
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.98.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
## What kind of change does this PR introduce?

see title, aims to address supabase#1252 and
supabase/auth-js#787


TODOs:

- [x] conduct an end to end test of the PR

---------

Co-authored-by: joel@joellee.org <joel@joellee.org>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
## What kind of change does this PR introduce?

see title, aims to address supabase#1252 and
supabase/auth-js#787


TODOs:

- [x] conduct an end to end test of the PR

---------

Co-authored-by: joel@joellee.org <joel@joellee.org>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
## What kind of change does this PR introduce?

see title, aims to address supabase#1252 and
supabase/auth-js#787


TODOs:

- [x] conduct an end to end test of the PR

---------

Co-authored-by: joel@joellee.org <joel@joellee.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants