Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: revert provider type to maintain backward compatibility #240

Merged
merged 5 commits into from
Oct 19, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion api/admin.go
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,8 @@ func (a *API) adminUserCreate(w http.ResponseWriter, r *http.Request) error {
if user.AppMetaData == nil {
user.AppMetaData = make(map[string]interface{})
}
user.AppMetaData["provider"] = []string{"email"}
user.AppMetaData["provider"] = "email"
user.AppMetaData["providers"] = []string{"email"}

err = a.db.Transaction(func(tx *storage.Connection) error {
if terr := models.NewAuditLogEntry(tx, instanceID, adminUser, models.UserSignedUpAction, map[string]interface{}{
Expand Down
3 changes: 2 additions & 1 deletion api/admin_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,8 @@ func (ts *AdminTestSuite) TestAdminUserCreate() {
require.NoError(ts.T(), json.NewDecoder(w.Body).Decode(&data))
assert.Equal(ts.T(), "test1@example.com", data.GetEmail())
assert.Equal(ts.T(), "123456789", data.GetPhone())
assert.Equal(ts.T(), []interface{}{"email"}, data.AppMetaData["provider"])
assert.Equal(ts.T(), "email", data.AppMetaData["provider"])
assert.Equal(ts.T(), []interface{}{"email"}, data.AppMetaData["providers"])
}

// TestAdminUserGet tests API /admin/user route (GET)
Expand Down
11 changes: 8 additions & 3 deletions api/external.go
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ func (a *API) internalExternalProviderCallback(w http.ResponseWriter, r *http.Re
if identity, terr = a.createNewIdentity(tx, user, providerType, identityData); terr != nil {
return terr
}
if terr = user.UpdateAppMetaDataProvider(tx); terr != nil {
if terr = user.UpdateAppMetaDataProviders(tx); terr != nil {
return terr
}
} else {
Expand Down Expand Up @@ -218,7 +218,7 @@ func (a *API) internalExternalProviderCallback(w http.ResponseWriter, r *http.Re
if terr = tx.UpdateOnly(identity, "identity_data", "last_sign_in_at"); terr != nil {
return terr
}
if terr = user.UpdateAppMetaDataProvider(tx); terr != nil {
if terr = user.UpdateAppMetaDataProviders(tx); terr != nil {
return terr
}
}
Expand Down Expand Up @@ -313,7 +313,12 @@ func (a *API) processInvite(ctx context.Context, tx *storage.Connection, userDat
if _, err := a.createNewIdentity(tx, user, providerType, identityData); err != nil {
return nil, err
}
if err = user.UpdateAppMetaDataProvider(tx); err != nil {
if err = user.UpdateAppMetaData(tx, map[string]interface{}{
"provider": providerType,
}); err != nil {
return nil, err
}
if err = user.UpdateAppMetaDataProviders(tx); err != nil {
return nil, err
}
if err := user.UpdateUserMetaData(tx, identityData); err != nil {
Expand Down
3 changes: 2 additions & 1 deletion api/invite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,8 @@ func (ts *InviteTestSuite) TestInviteExternalGitlab() {
ts.Require().NoError(err)
ts.Equal("Gitlab Test", user.UserMetaData["full_name"])
ts.Equal("http://example.com/avatar", user.UserMetaData["avatar_url"])
ts.Equal([]interface{}{"gitlab"}, user.AppMetaData["provider"])
ts.Equal("gitlab", user.AppMetaData["provider"])
ts.Equal([]interface{}{"gitlab"}, user.AppMetaData["providers"])
}

func (ts *InviteTestSuite) TestInviteExternalGitlab_MismatchedEmails() {
Expand Down
5 changes: 4 additions & 1 deletion api/signup.go
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,11 @@ func (a *API) signupNewUser(ctx context.Context, conn *storage.Connection, param
if user.AppMetaData == nil {
user.AppMetaData = make(map[string]interface{})
}
user.AppMetaData["provider"] = []string{params.Provider}

// TODO: Depcreate "provider" field
user.AppMetaData["provider"] = params.Provider

user.AppMetaData["providers"] = []string{params.Provider}
if params.Password == "" {
user.EncryptedPassword = ""
}
Expand Down
8 changes: 5 additions & 3 deletions api/signup_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ func (ts *SignupTestSuite) TestSignup() {
assert.Equal(ts.T(), "test@example.com", data.GetEmail())
assert.Equal(ts.T(), ts.Config.JWT.Aud, data.Aud)
assert.Equal(ts.T(), 1.0, data.UserMetaData["a"])
assert.Equal(ts.T(), []interface{}{"email"}, data.AppMetaData["provider"])
assert.Equal(ts.T(), "email", data.AppMetaData["provider"])
assert.Equal(ts.T(), []interface{}{"email"}, data.AppMetaData["providers"])
}

func (ts *SignupTestSuite) TestWebhookTriggered() {
Expand Down Expand Up @@ -119,8 +120,9 @@ func (ts *SignupTestSuite) TestWebhookTriggered() {

appmeta, ok := u["app_metadata"].(map[string]interface{})
require.True(ok)
assert.Len(appmeta, 1)
assert.EqualValues([]interface{}{"email"}, appmeta["provider"])
assert.Len(appmeta, 2)
assert.EqualValues("email", appmeta["provider"])
assert.EqualValues([]interface{}{"email"}, appmeta["providers"])

usermeta, ok := u["user_metadata"].(map[string]interface{})
require.True(ok)
Expand Down
6 changes: 3 additions & 3 deletions models/user.go
Original file line number Diff line number Diff line change
Expand Up @@ -214,14 +214,14 @@ func (u *User) UpdateAppMetaData(tx *storage.Connection, updates map[string]inte
return tx.UpdateOnly(u, "raw_app_meta_data")
}

// UpdateAppMetaDataProvider updates the provider field in AppMetaData column
func (u *User) UpdateAppMetaDataProvider(tx *storage.Connection) error {
// UpdateAppMetaDataProviders updates the provider field in AppMetaData column
func (u *User) UpdateAppMetaDataProviders(tx *storage.Connection) error {
providers, terr := FindProvidersByUser(tx, u)
if terr != nil {
return terr
}
return u.UpdateAppMetaData(tx, map[string]interface{}{
"provider": providers,
"providers": providers,
awalias marked this conversation as resolved.
Show resolved Hide resolved
})
}

Expand Down