fix: refactor Supabase AI API #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laktek
force-pushed
the
refactor-sb-ai
branch
from
d8f44ea
to
9b856a9
Compare
| esm_entry_point = "ext:sb_ai/ai.js", | ||
| esm = ["ai.js",] | ||
| ); | ||
|
|
||
| fn run_gte(state: &mut OpState, prompt: String) -> Result<Vec<f32>, Error> { | ||
| fn init_gte(state: &mut OpState) -> Result<(), Error> { |
There was a problem hiding this comment.
It would be interesting if we can make this op async and have the whole logic of initialization (if it's heavy) on a different thread. (I'm thinking especially because models can be large)
There was a problem hiding this comment.
@andreespirela Thanks for the suggestion! Refactored the init to run on a tokio task (ie. green thread)
examples/gte-small-ort/index.ts
Outdated
| Deno.serve(async (req: Request) => { | ||
| const params = new URL(req.url).searchParams; | ||
| const input = params.get('text'); | ||
| const output = Supabase_UNSTABLE.ai.runModel('gte', input); | ||
| const output = model.run(input); |
There was a problem hiding this comment.
Also wonder if the run op should be async...
|
🎉 This PR is included in version 1.36.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Modified to initialize session once and reuse internal session/tokenizer.