Skip to content

Commit

Permalink
ci: fix doubling of rc version identifier (#13)
Browse files Browse the repository at this point in the history
When an RC is published on top of an existing RC, the `rc` identifier
doubles. Example from
[`@supabase/auth-js`](https://www.npmjs.com/package/@supabase/auth-js/v/2.64.3-rc.rc.rc.3)
which uses pretty much the same Github Actions workflow file.

The fix is to change the `git describe --tags --exclude` to a value that
actually excludes [tags that start with
`rc`](https://github.com/supabase/ssr/releases/tag/rc0.4.0-rc.2).
  • Loading branch information
hf authored Jun 13, 2024
1 parent b6ae192 commit d01c628
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
# Use git describe tags to identify the number of commits the branch
# is ahead of the most recent non-release-candidate tag, which is
# part of the rc.<commits> value.
RELEASE_VERSION=$MAIN_RELEASE_VERSION-rc.$(node -e "console.log('$(git describe --tags --exclude *rc*)'.split('-')[1])")
RELEASE_VERSION=$MAIN_RELEASE_VERSION-rc.$(node -e "console.log('$(git describe --tags --exclude rc*)'.split('-')[1])")
# release-please only ignores releases that have a form like [A-Z0-9]<version>, so prefixing with rc<version>
RELEASE_NAME="rc$RELEASE_VERSION"
Expand Down

0 comments on commit d01c628

Please sign in to comment.