Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add support for storage key #61

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: add support for storage key #61

wants to merge 3 commits into from

Conversation

J0
Copy link
Contributor

@J0 J0 commented Sep 4, 2024 •
edited
Loading

What kind of change does this PR introduce?

Address #19 to allow developer to configure storageKey when using createBrowserClient() client side. Not relevant for server-side as cookies are used there.

@J0 J0 marked this pull request as ready for review September 11, 2024 14:09
@hf
Copy link
Collaborator

hf commented Sep 12, 2024

Wait why not createServerClient? These values must be synced up, otherwise wrong cookies will be read.

@J0
Copy link
Contributor Author

J0 commented Sep 12, 2024

Initial consideration was that on server side they'd be able to set it via: options?.cookieOptions?.name - was under impression from description that we primarily to want to allow the option of setting storageKey via options?.cookieOptions?.name on browser

It seems fine to allow this on createServerClient as well though. Pushed up to support on createServerClient as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@J0 @hf