Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add create method to handle token headers #630

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

silentworks
Copy link
Contributor

What kind of change does this PR introduce?

Add a new create method to handle async token retrieval

What is the current behavior?

The library isn't fully async and complains when trying to call get_session inside of _get_token_header from a @property.

What is the new behavior?

The library should now be fully async as the get_session can be called async since we've moved the _get_token_header to the new create method instead of calling it from a @property.

Additional context

Add any other context or screenshots.

@silentworks silentworks force-pushed the silentworks/full-async branch from f882b68 to 4f47306 Compare November 30, 2023 08:59
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (b9240d8) 46.15% compared to head (4f47306) 45.22%.

Files Patch % Lines
supabase/_async/client.py 0.00% 18 Missing ⚠️
supabase/_sync/client.py 50.00% 8 Missing ⚠️
supabase/client.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #630      +/-   ##
==========================================
- Coverage   46.15%   45.22%   -0.94%     
==========================================
  Files          13       13              
  Lines         299      314      +15     
==========================================
+ Hits          138      142       +4     
- Misses        161      172      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌶️ 🔥

@silentworks silentworks merged commit fd612a0 into main Dec 1, 2023
6 of 8 checks passed
@silentworks silentworks deleted the silentworks/full-async branch December 1, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants