Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unify http client to be httpx #83

Merged
merged 3 commits into from
Nov 17, 2021

Conversation

leynier
Copy link
Contributor

@leynier leynier commented Nov 15, 2021

Resolve #82

@dreinon
Copy link
Contributor

dreinon commented Nov 15, 2021

Update tests pls @leynier

@leynier
Copy link
Contributor Author

leynier commented Nov 15, 2021

Update tests pls @leynier

The import error occurs inside the gotrue-py library, apparently the old version of gotrue-py used requests without including it in its dependencies but being included in the supabase-py dependencies the tests worked fine

@leynier
Copy link
Contributor Author

leynier commented Nov 15, 2021

It is necessary to publish a new version of gotrue-py or point to the main branch as it was done with postgrest-py

@dreinon
Copy link
Contributor

dreinon commented Nov 15, 2021

Let's point the main branch for now

@leynier
Copy link
Contributor Author

leynier commented Nov 15, 2021

Let's point the main branch for now

I target the latest commits specifically, to avoid unexpected internal changes.

@leynier
Copy link
Contributor Author

leynier commented Nov 15, 2021

I'm fixing the tests right now

@dreinon dreinon merged commit 55e8f84 into supabase:develop Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify HTTP Client to be httpx
2 participants