Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove clickhouse init db #241

Merged
merged 2 commits into from
Feb 19, 2024
Merged

ci: remove clickhouse init db #241

merged 2 commits into from
Feb 19, 2024

Conversation

burmecia
Copy link
Member

What kind of change does this PR introduce?

This PR is to remove db initialisation for ClickHouse FDW test, as it is not supported by the latest ClickHouse docker image and it is actually not needed to set up a new database.

What is the current behavior?

The ClickHouse FDW test uses a database called supa.

What is the new behavior?

It is no need to set up a new database for testing, just use the default db is enought.

Additional context

This PR also updated the github action run command to remove warning Ignoring feature 'clickhouse_fdw,pg15'

@burmecia burmecia requested a review from imor February 19, 2024 00:05
@burmecia burmecia merged commit 5e398a3 into main Feb 19, 2024
2 checks passed
@burmecia burmecia deleted the ci/clickhouse-init-db branch February 19, 2024 05:23
kamyshdm pushed a commit to dymium-io/supabase-wrappers that referenced this pull request Jun 17, 2024
…s from 95239dd..5b5c262

5b5c262 Merge pull request supabase#233 from supabase/chore/use_create_async_runtime
ee74f6e Merge pull request supabase#239 from supabase/fix/scan-state-reset
42aa7e1 Merge branch 'fix/scan-state-reset' of github.com:supabase/wrappers into fix/scan-state-reset
8c2d58e fix: reset state when begin scan
5e398a3 Merge pull request supabase#241 from supabase/ci/clickhouse-init-db
6967050 format test code
72012b6 ci: remove clickhouse init db
cfe70d1 fix: reset state when begin scan
c169e7e chore(s3): revert use  create_async_runtime()
0788612 chore(s3): use existing create_async_runtime()

git-subtree-dir: DbGuardian/foreign_data_wrappers/supabase_wrappers
git-subtree-split: 5b5c262
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants