Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add a POC Notion FDW with users read only #264

Merged
merged 4 commits into from
May 28, 2024

Conversation

romaingrx
Copy link
Contributor

New Feature: Notion FDW

Overview

This pull request introduces a POC for a Notion FDW based on their REST API. The primary goal is to enable read-only integration with Notion, starting with the users endpoint as of now. This initial implementation serves as a foundation for future expansions to include additional endpoints.

Key Features

  • Initial Support for Users Endpoint: The current implementation supports read-only access to the users endpoint with query pushdown capabilities.
  • Testing: Includes a test server setup to mock Notion API responses configured in the .ci/docker-compose.yml file as well as the unit tests.
  • Extensibility for Future Endpoints: The architecture is designed with extensibility in mind (heavily based on the Stripe FWD), to facilitate the addition of the other endpoints later.

Future Work

  • Additional Endpoint Integration: Plan to extend support to other Notion API endpoints such as databases and pages, with read-only queries for the moment.

Local setup with the actual Notion API

wrappers_local_example

As I am relatively new to Rust, I welcome any feedback on best practices, code efficiency, or general Rust idioms that could enhance the implementation.

@burmecia
Copy link
Member

Thank you for the PR! Can you format the code so it can pass the CI check?

@romaingrx
Copy link
Contributor Author

Hello, it should be all good now. Sorry, totally forgot to run clippy and fmt locally on the 2 PRs.

Copy link
Member

@burmecia burmecia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Could you also add links in docs/index.md and mkdocs.yaml, so the docs can be generated?

@burmecia burmecia merged commit 1f68046 into supabase:main May 28, 2024
2 checks passed
@burmecia burmecia added the notion label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants