Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wasm): missing wasm package cache dir creation #298

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Conversation

burmecia
Copy link
Member

@burmecia burmecia commented Jul 4, 2024

What kind of change does this PR introduce?

This PR is to fix an issue with wasm package cache dir creation.

What is the current behavior?

The wasm foreign data wrapper (.wasm file) will be downloaded and saved to local cache folder when foreign table is queried. If the local cache doesn't exist yet, this operation will fail.

What is the new behavior?

Create the local cache folder if it doesn't exist before save the wasm file.

Additional context

This PR also added README and change logs for wasm foreign data wrapper.

@burmecia burmecia added wasm bug Something isn't working labels Jul 4, 2024
@burmecia burmecia requested a review from imor July 4, 2024 14:32
@burmecia burmecia merged commit 58af758 into main Jul 4, 2024
2 checks passed
@burmecia burmecia deleted the bo/fix/wasm-cache branch July 4, 2024 22:37
@burmecia burmecia mentioned this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants