Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the full server struct to the FDW when instanciating it #323

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

remilapeyre
Copy link
Contributor

The complete SQL command to create a foreign data wrapper is

CREATE SERVER [ IF NOT EXISTS ] server_name [ TYPE 'server_type' ] [ VERSION 'server_version' ]
    FOREIGN DATA WRAPPER fdw_name
    [ OPTIONS ( option 'value' [, ... ] ) ]

At this time only the options are given to the Foreign Data Wrapper implementation. This patch changes the signature of ForeignDataWrapper::new() to give it the full structure that matches PostgreSQL ForeignServer to expose the server_name, server_type and server_version attributes.

@burmecia burmecia added the enhancement New feature or request label Aug 9, 2024
Copy link
Member

@burmecia burmecia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks for the PR!

@burmecia burmecia merged commit 54325f0 into supabase:main Aug 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants