-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSCPD Doesn't Run Unless TEST_CASE_RUN is set #5483
Comments
Hi! Thanks for reporting this. Since super-linter v6, JSCPD lints the entire code base and not individual files. That snippet that you reference is to handle testing that particular linter and it's not needed otherwise. PS: Line 95 in 25cb7af
|
Sure but when I run it without a value for TEST_CASE_RUN JSCPD doesn’t run at all. When I run it with I should not have to include TEST_CASE_RUN to run JSCPD. |
This is correct. Also, when you Can you include the full debug log, not just a fragment, so we can see what's going on? |
Here's the full log file |
Let me reopen this while we investigate. On line 1814, the process to build the file list terminates successfully, but it doesn't seem to print the expected log line about JSCPD: super-linter/lib/functions/buildFileList.sh Lines 239 to 243 in 25cb7af
despite |
Export the TEST_CASE_RUN variable because subprocesses reference it when building the file list. Fix #5483
I was able to reproduce this. #5499 should fix the bug :) Thanks for reporting! |
Awesome thank you! And of course |
- Export the TEST_CASE_RUN variable because subprocesses reference it when building the file list. - Remove a duplicate file that we didn't catch because Jscpd was not running due to the TEST_CASE_RUN variable not being exported. Fix #5483
- Export the TEST_CASE_RUN variable because subprocesses reference it when building the file list. - Remove a duplicate file that we didn't catch because Jscpd was not running due to the TEST_CASE_RUN variable not being exported. Fix #5483
Is there an existing issue for this?
Current Behavior
JSCPD only runs if you specify TEST_CASE_RUN as true or false
Expected Behavior
JSCPD should still run even if you don't specify a value for TEST_CASE_RUN
Super-Linter version
Relevant log output
Steps To Reproduce
ex:
Anything else?
Relevant piece of code causing the issue:
super-linter/lib/functions/buildFileList.sh
Lines 239 to 243 in 25cb7af
It should either default to false somewhere or this check should be changed to
[[ "${TEST_CASE_RUN}" != "true" ]]"
The text was updated successfully, but these errors were encountered: