Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and install dependencies in dedicated stages #5078

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

ferrarimarco
Copy link
Collaborator

@ferrarimarco ferrarimarco commented Dec 31, 2023

Proposed Changes

  • Build and install dependencies in dedicated stages so we can run these steps in parallel with other steps.

Readiness Checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • If this is a breaking change, write upgrade instructions in the upgrade guide.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@ferrarimarco ferrarimarco added infrastructure related to project structure and maintenance O: backlog 🤖 Backlog, stale ignores this label labels Dec 31, 2023
@ferrarimarco ferrarimarco self-assigned this Dec 31, 2023
@ferrarimarco ferrarimarco changed the title build: python venvs and npm in dedicated stages build Python venvs and install npm packages in dedicated stages Dec 31, 2023
@ferrarimarco ferrarimarco force-pushed the build-venvs branch 4 times, most recently from 016da47 to ce098e2 Compare January 1, 2024 17:41
@ferrarimarco ferrarimarco marked this pull request as draft January 1, 2024 19:03
@ferrarimarco ferrarimarco force-pushed the build-venvs branch 2 times, most recently from 8a91a10 to 747cb4e Compare January 2, 2024 20:31
@ferrarimarco ferrarimarco changed the title build Python venvs and install npm packages in dedicated stages Build and install dependencies in dedicated stages Jan 3, 2024
@ferrarimarco ferrarimarco force-pushed the build-venvs branch 2 times, most recently from e623078 to 7bb528d Compare January 8, 2024 15:11
@ferrarimarco ferrarimarco marked this pull request as ready for review January 8, 2024 19:45
zkoppert
zkoppert previously approved these changes Jan 9, 2024
Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ferrarimarco ferrarimarco added this pull request to the merge queue Jan 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 10, 2024
Move the following tasks to dedicated stages so we can run these steps
in parallel with other stages:

- Build Python virtual environments
- Install npm packages
- Build clang-format
- Download and install TFlint plugins

Add missing target stage when building the container image
@ferrarimarco ferrarimarco merged commit df91117 into main Jan 10, 2024
10 checks passed
@ferrarimarco ferrarimarco deleted the build-venvs branch January 10, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure related to project structure and maintenance O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants