create universal macOS binaries #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that they are available for both configure and build steps
joshpar
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are getting ready to offer macOS binaries for both x86_64 and arm64 platforms, I tried enabling universal macOS builds for sc3-plugins as well.
I tested this briefly by booting scsynth and running an example from
Tartini's helpfile, and - after un-quarantining - the plugins worked on both arm64 machine with macOS 12 as well as x86_64 machine with macOS 10.10... full compatibility range.I also updated Xcode version to match the main SC release and made some minor cosmetic updates to the CI.