class library: make control set atomic #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tests if there are messages that could be canceled. This infers that messages were added by ‘addCancel’, and thus with the possible intention to be lazily evaluated. Thus, there is very little overhead for all other cases.
|
The branch breaks: crashes the interpreter |
This commit includes two fixes concerning the way arguments are passed to the internal synth control objects. 1) the old synth is released now with the current fade time. 2) pass extra arguments on send as a thunk, and not recursively (this was an accidental in one earlier commit)
When setting synth controls (the internal objects of a node proxy) directly, convert the arguments to OSC explicitly so that objects can be passed also to those.
Protect also NodeProxy:spawn from wrong arguments due to an async operation. This makes the method less efficient, but safer.
|
OK, fixed. So please test it extensively! |
|
@crucialfelix – because e wrote the |
| @@ -746,9 +745,9 @@ NodeProxy : BusPlug { | |||
|
|
|||
| // bundle: apply the node map settings to the entire group | |||
| sendAllToBundle { | bundle, extraArgs | | |||
| extraArgs = nodeMap.asOSCArgArray ++ extraArgs.value.asOSCArgArray; | |||
| var args = Thunk { nodeMap.asOSCArgArray ++ extraArgs.value.asOSCArgArray }; | |||
There was a problem hiding this comment.
better style IMO would be:
Thunk({ ... })which makes it clear that you are creating a Thunk object.
|
seems okay. its always better not to complicate the core classes, but there is already a bunch of junk in OSCBundle |
telephon
added a commit
that referenced
this pull request
Nov 11, 2015
class library: make control set atomic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fix by @telephon fixes an annoying behaviour in NodeProxies:
Previous behaviour:
now, it does it different... (maybe ask @telephon for details..)
I use this branch extensively for a week now and think that it works perfectly.