Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pyproject.toml instead of setup.py #115

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

petrjasek
Copy link
Member

also switched from black/flake8 to ruff

@petrjasek petrjasek requested a review from MarkLark86 December 18, 2024 09:51
Copy link
Collaborator

@MarkLark86 MarkLark86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change from black to ruff (performance)? We should probably use pyproject.toml in other repos too

pyproject.toml Outdated
license = {file = "LICENSE"}
authors = [
{name = "Petr Jasek"},
{name = "Mark Lark"},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be Mark Pittaway

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ sorry

@petrjasek
Copy link
Member Author

Why the change from black to ruff (performance)?

ruff handles both formatting and linting, so it can replace also flake8

We should probably use pyproject.toml in other repos too

yep I plan to do it but there is this babel issue python-babel/babel#777

@petrjasek petrjasek merged commit 580dfb6 into superdesk:elastic7 Dec 19, 2024
3 checks passed
@petrjasek petrjasek deleted the pyproject branch December 19, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants